Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to react-number-format v5 #1781

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Upgrade to react-number-format v5 #1781

merged 2 commits into from
Oct 4, 2022

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Oct 4, 2022 •
edited
Loading

Purpose

As title suggests. See the migration guide.

Approach and changes

Replaces #1778 to make sure this goes into the upcoming major.

  • Upgrades the dependency
  • Addresses breaking changes

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests (all green!)
  • Meets minimum browser support (read through the diff and it looks fine, and the TS target matches our support policy)
  • Meets accessibility requirements (⚠️ generally I'd like to get components using this library audited/test them with users. I have a bad feeling about the automatic cursor move on the DateInput, for example. But this is unrelated to the v5: will do separately.)

@vercel
Copy link

vercel bot commented Oct 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 2:50PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 0b10086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sumup-oss sumup-oss deleted a comment from sumup-clark bot Oct 4, 2022
@robinmetral robinmetral added the 📦 dependencies Pull requests that update a dependency file label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #1781 (0b10086) into next (b74822b) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1781      +/-   ##
==========================================
- Coverage   91.66%   91.60%   -0.06%     
==========================================
  Files         172      172              
  Lines        3526     3526              
  Branches     1129     1129              
==========================================
- Hits         3232     3230       -2     
- Misses        274      276       +2     
  Partials       20       20
Impacted Files Coverage Δ
...cuit-ui/components/CurrencyInput/CurrencyInput.tsx 100.00% <ø> (ø)
...ages/circuit-ui/components/DateInput/DateInput.tsx 92.30% <ø> (ø)
.../circuit-ui/hooks/useCollapsible/useCollapsible.ts 94.11% <0.00%> (-5.89%) ⬇️

@robinmetral robinmetral marked this pull request as ready for review October 4, 2022 15:06
@robinmetral robinmetral requested a review from a team as a code owner October 4, 2022 15:06
@robinmetral robinmetral requested review from connor-baer and removed request for a team October 4, 2022 15:06
@robinmetral robinmetral merged commit 5fe99fe into next Oct 4, 2022
@robinmetral robinmetral deleted the react-number-format-v5 branch October 4, 2022 16:26
@connor-baer connor-baer mentioned this pull request Oct 4, 2022
Merged
@robinmetral robinmetral mentioned this pull request Oct 31, 2022
Closed
@connor-baer connor-baer mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor-baer connor-baer connor-baer approved these changes

Assignees
No one assigned
Labels
🗂 circuit-ui 📦 dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinmetral @connor-baer